Add Result controls (Fullscreen, hide-results, edit snippet) buttons to Snippet View #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a21cdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alizaberger
requested changes
May 13, 2025
Collaborator
There was a problem hiding this comment.
The code is exceptionally well-written and clear. I noticed 2 issues:
- The expand button does not behave the way it did in the legacy editor and in the Figma. There the behavior was to expand the entire snippet content, not just the results pane. The expanded snippet should have the snippet code, the buttons, and the results pane.
- When building locally, I got his error.
Module not found: Error: Can't resolve '@stackoverflow/stacks-icons/src/Icon/StackSnippets.svg' in 'C:\Users\aberger\source\repos\Stacks-Editor\src\styles'
giamir
requested changes
May 13, 2025
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Happy to approve as soon as the styling part is addressed. Thanks @threefjefff
giamir
reviewed
May 13, 2025
giamir
approved these changes
May 13, 2025
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Thanks for addressing my comment @threefjefff
alizaberger
requested changes
May 13, 2025
alizaberger
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds: